Closed Bug 918464 Opened 12 years ago Closed 11 years ago

Fix zamboni po file errors

Categories

(addons.mozilla.org Graveyard :: Localization, defect)

Product:
addons.mozilla.org Graveyard
Component:
Localization
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kumar, Assigned: CocoMo)

Details

Attachments

(1 file, 2 obsolete files)

zamboni-lint3.txt
146.26 KB, text/plain
Details
Attached file zamboni-lint.txt (obsolete) —
Here is the lint summary from Zamboni's po files (using dennis-cmd): Final totals Number of files examined: 102 Total number of files with errors: 27 Total number of warnings: 465 Total number of errors: 228 The errors generally mean users in the locales will see a traceback so we should fix those. Some errors are contextual (a word is missing) so it's not as serious but still a problem. A lot of errors are for the dbg locale so we can ignore all those. Warnings Errors Filename 135 134 dbg (messages.po) 22 21 sl (messages.po) 8 8 fr (messages.po) 11 7 tr (messages.po) 11 7 el (messages.po) 7 7 zh_CN (messages.po) 7 7 dbg (javascript.po) 6 5 ca (messages.po) 4 4 ja (messages.po) 134 3 ar (messages.po) 4 3 hu (messages.po) 22 2 eu (messages.po) 6 2 de (messages.po) 5 2 sq (messages.po) 2 2 cs (messages.po) 0 2 vi (messages.po) 0 2 ga_IE (messages.po) 12 1 eu (javascript.po) 3 1 th (messages.po) 3 1 pt_BR (messages.po) 3 1 it (messages.po) 2 1 es (messages.po) 1 1 nl (messages.po) 1 1 nl (javascript.po) 1 1 id (messages.po) 0 1 mn (messages.po) 0 1 fi (messages.po) 12 0 he (javascript.po) 9 0 ar (javascript.po) 8 0 he (messages.po) 4 0 pl (messages.po) 4 0 pl (javascript.po) 4 0 ko (messages.po) 3 0 de (javascript.po) 2 0 sk (javascript.po) 1 0 zh_TW (messages.po) 1 0 sv_SE (messages.po) 1 0 ru (messages.po) 1 0 pt_PT (messages.po) 1 0 pt_PT (javascript.po) 1 0 da (messages.po) 1 0 da (javascript.po) 1 0 bg (messages.po) 1 0 bg (javascript.po)
Fixed for cs. Thanks!
There are 2 warnings in the list for sk and both are FPs.
The errors are more important to fix than the warnings. Each error means that a user will probably get a 500 error when trying to load the page.
Peiying: The files above have errors in them. These are all only for zamboni. The attachment has details about specific problems. Would you reach out to the localizers and let them know about the errors? You can ignore dbg.
Ok, i will check with the communities about this.
Assignee: nobody → pmo
Based on bug 930323 comment 2, it would have probably been useful to regenerate this file before notifying localizers (unless there's another explanation for the missing string).
Attached file zamboni-lint2.txt (obsolete) —
Here is a new log of errors/warnings from today's po files. You can ignore dbg. The most important ones to fix are the errors. Those could be creating 500 responses. Final totals Number of files examined: 148 Total number of files with errors: 15 Total number of warnings: 605 Total number of errors: 161 Warnings Errors Filename 143 135 dbg (messages.po) 7 7 dbg (javascript.po) 14 6 fr (messages.po) 7 2 sq (messages.po) 28 1 eu (messages.po) 14 1 ga_IE (messages.po) 10 1 pt_BR (messages.po) 8 1 nl (messages.po) 8 1 hu (messages.po) 5 1 th (messages.po) 5 1 fi (messages.po) 4 1 zh_CN (messages.po) 3 1 id (messages.po) 1 1 nl (javascript.po) 0 1 mn (messages.po) 151 0 ar (messages.po) 14 0 pl (messages.po) 12 0 he (javascript.po) 11 0 ru (messages.po) 11 0 eu (javascript.po) 10 0 sk (messages.po) 10 0 cs (messages.po) 9 0 he (messages.po) 9 0 el (messages.po) 9 0 ar (javascript.po) 8 0 pt_PT (messages.po) 8 0 ko (messages.po) 8 0 da (messages.po) 8 0 bg (messages.po) 7 0 it (messages.po) 7 0 es (messages.po) 7 0 en_US (messages.po) 7 0 ca (messages.po) 6 0 de (messages.po) 5 0 zh_TW (messages.po) 5 0 af (messages.po) 4 0 sl (messages.po) 4 0 pl (javascript.po) 4 0 ja (messages.po) 3 0 tr (messages.po) 3 0 sv_SE (messages.po) 2 0 uk (messages.po) 2 0 sk (javascript.po) 1 0 vi (messages.po) 1 0 pt_PT (javascript.po) 1 0 da (javascript.po) 1 0 bg (javascript.po)
Attachment #807379 - Attachment is obsolete: true
Is it possible to include this linting in the .mo build step? Any error could possibly be dropped from the .mo so it doesn't cause us to 500?
(In reply to Rob Hudson [:robhudson] from comment #8) > Is it possible to include this linting in the .mo build step? Any error > could possibly be dropped from the .mo so it doesn't cause us to 500? I actually don't think we are 500ing. We catch the error in our templates and just show english instead. Still valid to fix errors though.
after these errors are fixed we should add the dennis-cmd linter to Zamboni's test suite. That way we'll be notified of errors as soon as the po file is checked in. For bonus points we can hook the test suite up to pull requests.
Kumar, have you fixed your script so localizers can be notified on the errors as soon as they are checking in the file. Also, do you have a new report on this? I wonder how many locales have resolved the issues. I will chase those that are either live or on the next release wave.
Attached file zamboni-lint3.txt —
Hi Peiying. Here is a new report. I am waiting until there are 0 errors before adding the script to check on commit because otherwise it would constantly fail. Final totals Number of files examined: 148 Total number of files with errors: 12 Total number of warnings: 602 Total number of errors: 154 Warnings Errors Filename 144 136 dbg (messages.po) 7 7 dbg (javascript.po) 7 2 sq (messages.po) 28 1 eu (messages.po) 10 1 pt_BR (messages.po) 8 1 hu (messages.po) 5 1 th (messages.po) 5 1 fi (messages.po) 4 1 zh_CN (messages.po) 3 1 id (messages.po) 1 1 nl (javascript.po) 0 1 mn (messages.po) ...
Attachment #821724 - Attachment is obsolete: true
Hi Kumar, Thanks for the latest report. I see a lot of corrupted characters in different languages. Is this the result of the submission or the text file not saved in UTF-8 that I can't see the report correctly? Do you mind sending me another one with characters properly displayed? I was going to share the report with the community but as is, it is hard to show the smaller mistakes that contribute to the errors. Thanks, Peiying
Oh. Can you point out an example of a corrupted character? I guess it's either a bug in the tool I used to generate the report or the original po file also had corrupted characters.
At a glance, I don't see any corruption either, for what it's worth.
The attachment is fine as it turns out but when I view it in "edit as comment" mode, seems like all non-ASCII characters are corrupted, I guess it is a bugzilla bug.
fixed the error messages reported in comment #12.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: